v3 - include non-dynamic pages in SEO fetching #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -77,7 +77,7 @@ export const SLUG_QUERY = groq` | |||
| `; | |||
|
|
|||
| export const SEO_SLUG_QUERY = groq` | |||
| *[_type == "pageBuilder" && slug.current == $slug][0]{ | |||
| *[defined(seo) && slug.current == $slug][0]{ | |||
There was a problem hiding this comment.
how would this transfer for documents where we don't have or want seo? I'm assuming the default SEO would then be the fallback? Say for Legal documents
There was a problem hiding this comment.
This PR does not change that behavior. Here we only say that any page with a field seo should use that data for SEO metadata, otherwise use default SEO. Opting out of SEO for a page, like legal documents, is not currently possible.
christinaroise
approved these changes
Sep 23, 2024
anemne
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #694
Currently, SEO data is not fetched for non-dynamic pages. This is becuase the query has a filter on the
pageBuildertype. This has been changed to filter based on the existence of theseofield instead. This means that pages such asCompensationsandCustomerCasePagealso get SEO metadata.CustomerCasePagewas missing the seo fields, so this has also been added.Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: